Parser turns html entities to strings #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siefkenj
reviewed
May 27, 2024
| cursor.name === "Ampersand" || | ||
| cursor.name === "EntityReference" || | ||
| cursor.name === "CharacterReference" | ||
| ) { |
There was a problem hiding this comment.
parser.ts is only used in legacy code, right? The new DAST code doesn't touch it?
There was a problem hiding this comment.
There are other exports from parser.ts used in the new code, but they don't use the parseAndCompile export, which is the one changed in this PR. (If the had used parseAndCompile, they would have been losing any entities, etc.
|
Looks good to me! It'll be good to have all the tests working :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the doenetml parser converts html entities and the like into strings and merges consecutive strings.
With this change, cypress tests are finally passing again.