Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Reveal Not Covering Entire Image #534

Closed
ghost opened this issue Jan 27, 2015 · 4 comments
Closed

Card Reveal Not Covering Entire Image #534

ghost opened this issue Jan 27, 2015 · 4 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jan 27, 2015

Hey! I found a bug!

Basically if you create card reveal and put less than one line of text, it only covers part of the image...

EX:

@ghost
Copy link
Author

ghost commented Jan 27, 2015

One other bug.

Create a reveal card, press the image and bring up this screen: http://i.imgur.com/EN1fDlj.png

Then click anywhere else on the screen. I would expect that it minimizes, but it doesnt.

Hope that makes sense.

@acburst acburst self-assigned this Jan 27, 2015
@acburst
Copy link
Collaborator

acburst commented Jan 27, 2015

Hmm, can I see your code? I'm pretty sure we make the card reveal stretch to fit the card always.

@acburst
Copy link
Collaborator

acburst commented Jan 27, 2015

Also we do not intend to make it close by clicking elsewhere on the screen because it doesn't interfere with any part of the page while it is open. This is by design and can be seen on google sites.

@acburst acburst closed this as completed Jan 27, 2015
@ghost
Copy link
Author

ghost commented Jan 27, 2015

https://gist.github.com/nahtnam/e57b3065a697f114ad9a

On Tue Jan 27 2015 at 12:54:54 PM Alan Chang notifications@github.com
wrote:

Also we do not intend to make it close by clicking elsewhere on the screen
because it doesn't interfere with any part of the page while it is open.
This is by design and can be seen on google sites.


Reply to this email directly or view it on GitHub
#534 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant