Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: insertMarkdownContent didn't insert Markdown correctly in plain-text documents #13

Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix: insertMarkdownContent didn't insert Markdown correctly in plain-text documents #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/extensions/core/extra-editor-commands/commands/insert-markdown-content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { RawCommands } from '@tiptap/core'
import { DOMParser } from 'prosemirror-model'

import { parseHtmlToElement } from '../../../../helpers/dom'
import { isPlainTextDocument } from '../../../../helpers/schema'
import { createHTMLSerializer } from '../../../../serializers/html/html'

import type { ParseOptions } from 'prosemirror-model'
Expand Down Expand Up @@ -39,9 +38,7 @@ function insertMarkdownContent(
// Check if the transaction should be dispatched
// ref: https://tiptap.dev/api/commands#dry-run-for-commands
if (dispatch) {
const htmlContent = !isPlainTextDocument(editor.schema)
? createHTMLSerializer(editor.schema).serialize(markdown)
: markdown
const htmlContent = createHTMLSerializer(editor.schema).serialize(markdown)

// Inserts the HTML content into the editor while preserving the current selection
tr.replaceSelection(
Expand Down