Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): revert dependency conventional-changelog-conventionalcommits to v6.1.0 #430

Merged

Conversation

rfgamaral
Copy link
Member

Overview

Unfortunately, #429 does not work because dependency resolutions fails, and while it would likely still work if we forced it, it doesn't feel like the right course of action.

Instead, to fix semantic-release/semantic-release#2932, we are reverting the dependency that is actually causing issues. Once the new stable version of semantic-release is released, we can upgrade conventional-changelog-conventionalcommits to v7 again.

Note
This PR also enables manual triggers for the Typist Package Release workflow so that we can test that all is working. The workflow_dispatch trigger should be removed once everything is working without issues.

PR Checklist

Test plan

This needs to be merged, and this workflow manually triggered to properly test that this is working.

@rfgamaral rfgamaral added the ⛴ Ship PR Used for PRs that don't need a review and can be merged when CI is green. label Sep 5, 2023
@rfgamaral rfgamaral self-assigned this Sep 5, 2023
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for doist-typist ready!

Name Link
🔨 Latest commit a13b434
🔍 Latest deploy log https://app.netlify.com/sites/doist-typist/deploys/64f703cdd471460008d15c54
😎 Deploy Preview https://deploy-preview-430--doist-typist.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rfgamaral rfgamaral enabled auto-merge (squash) September 5, 2023 10:33
@rfgamaral rfgamaral merged commit 52eb054 into main Sep 5, 2023
9 checks passed
@rfgamaral rfgamaral deleted the ricardo/revert-conventional-changelog-conventionalcommits branch September 5, 2023 10:34
@doistbot
Copy link
Member

doistbot commented Sep 5, 2023

🎉 This PR is included in version 1.4.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doistbot doistbot added the released Pull requests that have been released to production label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Pull requests that have been released to production ⛴ Ship PR Used for PRs that don't need a review and can be merged when CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for errors resulting in a zero exit code
2 participants