incorrect page numbering in PDF

[GildDart]

Bug

In v18.0.5 (php 8.0.30) the page numbering in the Propale pdf is incorrect. It is in the form: 1/2, 2/3, 3/4, 4/4 instead of 1/4, 2/4, 3/4, 4/4 (azure and cyan models).

On the same server and configuration it is correct for v17.0.3

Dolibarr Version

18.0.5

Environment PHP

8.0.3

Environment Database

10.6.17-MariaDB

Steps to reproduce the behavior and expected behavior

No response

Attached files

No response

[sonikf]

Hi @GildDart
Can you check if PDF_USE_GETALIASNBPAGE_FOR_TOTAL set to 1 fixes your problem and if numbering is in correct position?

[GildDart]

Great it works !!!
Thank you sonikf.

[sonikf]

Hi @GildDart
Can you reopen? This is actually a bug and is reproducible in 19.0.1 and 20.0.0-alpha

[GildDart]

Done...

[fappels]

Have put this on high priority, had more complaints on this. Some Authorities do not accept invoices with incorrect page numbering.

[sonikf]

Hi @fappels,
Can we collaborate on this?
Problem is here

dolibarr/htdocs/core/lib/pdf.lib.php

Lines 1355 to 1365 in e2eb4e9

	// Show page nb only on iso languages (so default Helvetica font)
	$pdf->SetXY($dims['wk'] - $dims['rm'] - 18 - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_X', 0), -$posy - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_Y', 0));
	if (getDolGlobalString('PDF_USE_GETALIASNBPAGE_FOR_TOTAL')) {
	// $pagination = $pdf->getAliasNumPage().' / '.$pdf->getAliasNbPages(); // works with $pdf->Cell
	$pagination = $pdf->PageNo().' / '.$pdf->getAliasNbPages(); // seems to not work with all fonts like ru_UK
	} else {
	$pagination = $pdf->PageNo().' / '.$pdf->getNumPages(); // seems to always work even with $pdf->Cell. But some users have reported wrong nb (no way to reproduce)
	}
	$pdf->MultiCell(18, 2, $pagination, 0, 'R', 0);

For countries using Freemono or DejaVuSans instead of default Helvetica font only const PDF_USE_GETALIASNBPAGE_FOR_TOTAL works but renders wrong

line 1365 should change from
$pdf->MultiCell(18, 2, $pagination, 0, 'R', 0);
to
$pdf->MultiCell(30, 2, $pagination, 0, 'R', 0);

[fappels]

Maybe make PR for V18 like:

if (in_array(pdf_getPDFFont($outputlangs), array('Freemono',  'DejaVuSans'))) {
    $pdf->MultiCell(30, 2, $pagination, 0, 'R', 0);
} else {
    $pdf->MultiCell(18, 2, $pagination, 0, 'R', 0);
}

and remove PDF_USE_GETALIASNBPAGE_FOR_TOTAL to keep only getAliasNbPages

[sonikf]

@fappels , @GildDart
Can you test following code? It works for me in 18.0.5, 19.0.1 and 20.0.0-alpha

	// Show page nb only on iso languages (so default Helvetica font)
		$pdf->SetXY($dims['wk'] - $dims['rm'] - 18 - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_X', 0), -$posy - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_Y', 0));
		$pagination = $pdf->PageNo().' / '.$pdf->getAliasNbPages();
		if (in_array(pdf_getPDFFont($outputlangs), array('Freemono',  'DejaVuSans'))) {
    		$pdf->MultiCell(30, 2, $pagination, 0, 'R', 0);
		} else {
    		$pdf->MultiCell(18, 2, $pagination, 0, 'R', 0);
		}

[fappels]

@sonikf , @GildDart
Was still not working for 'Freemono', should be 'freemono'
Changed code also a bit, can you test?
I tested on all font found in main.lang

[GildDart]

It is working with my v18.0.5.

[sonikf]

@fappels
Somehow both 'Freemono' and 'freemono' works for me!
Tested again in 18.0.5, 19.0.1 and 20.0.0-alpha and it works!
Position with your code is a little bit off though even with $paginationWidth = 30;, can't figure out why...
freemono

DejaVuSans

@GildDart
is position ok for you?

[GildDart]

Could be a little lower and aligned at the right with the line above...

[fappels]

I put PR on draft, if you have better value for width and position I change in PR.

[GildDart]

@fappels Where can I find the values ?

[sonikf]

@fappels
Initial code you proposed worked better, apart from 'Freemono' and 'freemono' problem what else was wrong with your tests?

@GildDart
Did you test initial code proposal?
reposting with freemono correction....

	// Show page nb 
		$pdf->SetXY($dims['wk'] - $dims['rm'] - 18 - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_X', 0), -$posy - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_Y', 0));
		$pagination = $pdf->PageNo().' / '.$pdf->getAliasNbPages();
		if (in_array(pdf_getPDFFont($outputlangs), array('freemono',  'DejaVuSans'))) {
    		$pdf->MultiCell(30, 2, $pagination, 0, 'R', 0);
		} else {
    		$pdf->MultiCell(18, 2, $pagination, 0, 'R', 0);
		}

[fappels]

I pushed some correction, put 28 not 30, because think will have problem with doc more the 10 pages.
Also keep original alignment for standard font (others then freemone and DejaVuSans). Is patch for fix page numbering, not a patch for better alignment. Better alignment fix should be pushed only to V20.

[sonikf]

Hi @fappels
ok much better now!

[GildDart]

@sonikf

Here is what I put...

` // Show page nb only on iso languages (so default Helvetica font)

$pdf->SetXY($dims['wk'] - $dims['rm'] - 18 - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_X', 0), -$posy - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_Y', 0));

$pagination = $pdf->PageNo().' / '.$pdf->getAliasNbPages();

	if (in_array(pdf_getPDFFont($outputlangs), array('Freemono',  'DejaVuSans'))) {
		$pdf->MultiCell(30, 2, $pagination, 0, 'R', 0);
	} else {
		$pdf->MultiCell(18, 2, $pagination, 0, 'R', 0);
	}

`

instead of

`
// Show page nb only on iso languages (so default Helvetica font)
$pdf->SetXY($dims['wk'] - $dims['rm'] - 18 - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_X', 0), -$posy - getDolGlobalInt('PDF_FOOTER_PAGE_NUMBER_Y', 0));

if (getDolGlobalString('PDF_USE_GETALIASNBPAGE_FOR_TOTAL')) {
	// $pagination = $pdf->getAliasNumPage().' / '.$pdf->getAliasNbPages(); 	// works with $pdf->Cell
	$pagination = $pdf->PageNo().' / '.$pdf->getAliasNbPages();	// seems to not works with all fonts like ru_UK
} else {
	$pagination = $pdf->PageNo().' / '.$pdf->getNumPages();		// seems to always work even with $pdf->Cell. But some users has reported wrong nb (no way to reproduce)
}

$pdf->MultiCell(18, 2, $pagination, 0, 'R', 0);

`

[fappels]

I close this one, is now fixed in branch 18.
@sonikf & @GildDart , thanks for helping on this.