Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX for MAIN_MAXTABS_IN_CARD = $i card #11685

Merged
merged 2 commits into from
Aug 22, 2019
Merged

FIX for MAIN_MAXTABS_IN_CARD = $i card #11685

merged 2 commits into from
Aug 22, 2019

Conversation

ptibogxiv
Copy link
Contributor

Fix for if MAIN_MAXTABS_IN_CARD = number of cards, the last card don't displaying

@ptibogxiv ptibogxiv closed this Aug 13, 2019
@ptibogxiv ptibogxiv reopened this Aug 13, 2019
@ptibogxiv ptibogxiv closed this Aug 13, 2019
@ptibogxiv ptibogxiv reopened this Aug 13, 2019
@eldy
Copy link
Member

eldy commented Aug 15, 2019

I don't see any trouble with old code. May be problem is just defintion of MAIN_MAXTABS_IN_CARD
MAIN_MAXTABS_IN_CARD is number of tabs clicable (is does not count the link "+" to see other tabls)

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Aug 15, 2019
@ptibogxiv
Copy link
Contributor Author

indeed it's only affect if MAIN_MAXTABS_IN_CARD is egal to real count of tabs

@eldy eldy merged commit 2bc0163 into Dolibarr:10.0 Aug 22, 2019
@eldy eldy mentioned this pull request Aug 22, 2019
Merged
eldy added a commit that referenced this pull request Aug 22, 2019
@eldy
FIX #11685
cdda08c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptibogxiv @eldy