FIX Accountancy generic suggest account not proposed

[aspangaro]

Before :

After (With constant ACCOUNTANCY_AUTOFILL_ACCOUNT_WITH_GENERIC)

[eldy]

The rule was to check the box when Dolibarr is sure "automatically".
Here, there is no account for the product, so dolibarr can suggest the default value, but he is not sure it is good so i think we must have the value "autoselected" but no the checkbox.
So default behavior should be an intermediate of actual and the one suggested with option ACCOUNTANCY_AUTOFILL_ACCOUNT_WITH_GENERIC, shouldn't it ?

[aspangaro]

Thanks @eldy for your reflexion.

No, until now (branch v9 and previous), the checkbox is check at the "green" first level (With product account defined and default_account defined) and also at the "orange" second level (Only with default account_defined) to win a lot of time especially when there are a lot of lines waiting when you start an accounting for example or for companies where there are extremely fast lines and they use half the accountancy module.
For the moment, it's a regression. I validate the constant because I think it's a good idea but even compared to my patch, it would be necessary to reverse the operation. Enable by default the checkbox with a level 2 and disable the checkbox with the constant. What do you think about that ?

Available tomorrow to talk about it in person if you want