Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #26100 - Ticket - On edit, list of closed project must be excluded #26223

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

aspangaro
Copy link
Member

Difference between creation and display/modification phases

On ticket create mode, closed project are not available.
On ticket view mode, closed project are available.

Propose to access to closed projects in ticket create mode

@eldy
Copy link
Member

eldy commented Oct 15, 2023

The only goal of closing a project is to be sure they are not used anymore into other created object like tickets (closing project = "i don't want this project to be included into new object").
If we include then in creation of tickets, what is goal of closing a project ?

For edit, project must appear into list if it is already set, but we should not be able to modify to switch on a closed project (except if we open the project for that).

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Oct 15, 2023
@aspangaro
Copy link
Member Author

aspangaro commented Oct 16, 2023

Thanks @eldy

In this case, compared to my first PR, I propose to invert how it works because for the moment, when you edit a project on ticket, you see closed projects:

image

I push a new PR for:
No access to close projects on creation
No access to close projects on edit

@aspangaro aspangaro changed the title FIX #26100 - Ticket - On creation, list of closed project are excluded FIX #26100 - Ticket - On edit, list of closed project must be excluded Oct 16, 2023
@eldy
Copy link
Member

eldy commented Oct 20, 2023

I confirm that closed project must even not appear into combo list. Don't forget that nb of project increase with time. But list of values into combo must remain with a qty that is stable (only active project)

Can you confirm that if we edit an object (ticket) and the project is a closed project we can still keep the current value. Only changing for a closed project is not allowed. Can you confirm this is what you did ?

@eldy eldy merged commit a17447c into Dolibarr:14.0 Oct 20, 2023
2 checks passed
@edupulpillo
Copy link

edupulpillo commented Jan 21, 2024

The closed proyects also should be availble when a ticket is created.
After a project is closed, a garantee about it can be stablished, and then still maintenance tickets can arise.
So maybe a special setup in the ticket module: Allow to select closed projects YES/NO, can be the best solution.

At the moment if a customer have garantee about a project already closed, when a ticket is created, force us to open the project, create a ticket, and close the project again.

About the question of Eldy "If we include then in creation of tickets, what is goal of closing a project ?" the goal of closing a project is to establish that the project execution phase is end. This means can invoice it etc. But a project that is closed, can have an aftersales service. This is why still is needed to be able to select a closed project when a ticket is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants