NEW: Invoice subtypes for customers and vendors

[sonikf]

Re up

[eldy]

Possible SQL Injection here.
Use
$sql .= " WHERE f.ref = '".$this->db->escape($this->ref)."'";
The quotes for SQL must be ' and content must be escaped.

[sonikf]

Fixed

[eldy]

Hard coded value are not allowed. I suggest to remove completely this check for the first version of the PR.

[sonikf]

Fixed
Any suggestion on how i could tackle this because it's about the most common mistake made by users having to choose between so many subtypes and is driving accountants crazy!?

fyi the hardcoded values i used are from the revenue ministry api and never gonna change.

[eldy]

Same here

[sonikf]

Fixed

[sonikf]

@eldy
Testing my changes using develop i got
Fatal error: Uncaught Error: Class 'Facture' not found in /fourn/facture/list.php:1524 Stack trace: #0 {main} thrown in /fourn/facture/list.php on line 1524

following code gives the error and it is actually used in /compta/facture/list.php with out errors.
I tried changing Facture to FactureFournisseur as i thought to be a typo but then i got
Fatal error: Uncaught Error: Call to a member function getAvailableDiscounts() on null
Any idea?

	if ($facturestatic->status == Facture::STATUS_CLOSED && $facturestatic->close_code == 'discount_vat') {		// If invoice closed with discount for anticipated payment
		$remaintopay = 0;
		$multicurrency_remaintopay = 0;
	}
	if ($facturestatic->type == Facture::TYPE_CREDIT_NOTE && $obj->paye == 1) {		// If credit note closed, we take into account the amount not yet consumed
		$remaincreditnote = $discount->getAvailableDiscounts($companystatic, '', 'rc.fk_facture_source='.$facturestatic->id);
		$remaintopay = -$remaincreditnote;
		$totalpay = price2num($facturestatic->total_ttc - $remaintopay);
		$multicurrency_remaincreditnote = $discount->getAvailableDiscounts($companystatic, '', 'rc.fk_facture_source='.$facturestatic->id, 0, 0, 1);
		$multicurrency_remaintopay = -$multicurrency_remaincreditnote;
		$multicurrency_totalpay = price2num($facturestatic->multicurrency_total_ttc - $multicurrency_remaintopay);
	}