FIX warning param $lineID getSpecialCode is negatif #26826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Nov 23, 2023
htdocs/core/lib/pdf.lib.php
Outdated
| @@ -1351,7 +1351,7 @@ function pdf_writelinedesc(&$pdf, $object, $i, $outputlangs, $w, $h, $posx, $pos | |||
| //if (is_object($hookmanager) && ( (isset($object->lines[$i]->product_type) && $object->lines[$i]->product_type == 9 && ! empty($object->lines[$i]->special_code)) || ! empty($object->lines[$i]->fk_parent_line) ) ) | |||
| if (is_object($hookmanager)) { // Old code is commented on preceding line. Reproduct this test in the pdf_xxx function if you don't want your hook to run | |||
| $special_code = empty($object->lines[$i]->special_code) ? '' : $object->lines[$i]->special_code; | |||
| if (!empty($object->lines[$i]->fk_parent_line)) { | |||
| if ($object->lines[$i]->fk_parent_line > 0) { | |||
There was a problem hiding this comment.
In case of fk_parent_line is not defined or null, both test are required to avoid warning with php 8.2
if (!empty($object->lines[$i]->fk_parent_line) && $object->lines[$i]->fk_parent_line > 0) {
There was a problem hiding this comment.
OK, I've made the change
eldy
added
the
PR to fix - See feedback in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX|Fix #[value $idLine méthode getSpecialCode()]
Implement a condition to prevent the $lineId parameter from being negative in the getSpecialCode() method
The getSpecialCode() method is only executed if $object->lines[$i]->fk_parent_line is greater than 0