FIX 16.0 - parent company gets emptied when updating a third party from the card in edit mode #28269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om the card in edit mode This is because the field's value is set using GETPOST even when no corresponding <input> is present in the form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX 16.0 parent company empty after editing a third party card
Reproducing in Dolibarr 16
Expected: B still has a parent company (A)
Actual: B no longer has a parent company
This is because in v16.0, in edit mode, there is no form input for the parent company, but the field is still set using
GETPOST('parent_company_id', 'int').In v17, there is a form input for the parent company in edit mode, which fixes the bug. However, backporting this in v16 would arguably be a new feature.