FIX: it was not possible to set all supplier invoice lines VAT to 0% #29417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invoice On a supplier invoice, when you want to set all lines VAT to 0, the check performed in card.php fails and an error occurs. The 0 value was interpreted as false so we never enter in the "if" condition. We now check that the value is not an empty string
spooky360
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a supplier invoice, when you want to set all lines VAT to 0, the check performed in card.php fails and an error occurs. The 0 value was interpreted as false so we never enter in the "if" condition. We now check that the value is not an empty string