FIX: made invalid code shape error more user friendly #29498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Apr 26, 2024
htdocs/barcode/printsheet.php
Outdated
| @@ -231,7 +231,7 @@ | |||
| 'code'=>$code, | |||
| 'encoding'=>$encoding, | |||
| 'is2d'=>$is2d, | |||
| 'photo'=>$barcodeimage // Photo must be a file that exists with format supported by TCPDF | |||
| 'photo'=>!empty($barcodeimage) ?? '' // Photo must be a file that exists with format supported by TCPDF | |||
There was a problem hiding this comment.
What !empty($barcodeimage) ?? '' means ?
eldy
added
the
Discussion
|
I changed this line (I changed it again because I made a mistake) because before, the barcode pdf would never be loaded because of an undefined variable. It was fixed in 18.0 version but not in 17.0. Also, my first fixing goal here was the not user friendly logic error when the barcode had an invalid shape (it was dying and throwing outside dolibarr app without saying what could have happened) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a barcode had an invalid shape, the page would die, now we use the error, catch it and send a pop up the the user so that he is told about what could have caused this error.