Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : Display the date according to user language on subsitutions #29510

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

ksar-ksar
Copy link
Contributor

@eldy eldy added PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) and removed PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) labels Apr 27, 2024
@eldy eldy merged commit 3df1490 into Dolibarr:17.0 Apr 27, 2024
3 checks passed
eldy added a commit that referenced this pull request Apr 27, 2024
@frederic34
Copy link
Member

frederic34 commented May 10, 2024

@mdeweerd is it possible that codespell checks commit message to avoid errors in changelog?

@mdeweerd
Copy link
Contributor

@frederic34 I think that should be possible with the commit-msg hook.

[pre-commit](https://pre-commit.com/#commit-msg)

However, just adding the following does not work, so a "local" hook may be needed:

      - id: codespell
        stages: [commit-msg]
        name: codespell-commit-msg

I found another project where it is configured that way so I wonder if it just does not work not for me (my setup being a bit "speciam") - see https://forge.softwareheritage.org/differential/changeset/?ref=117189 .

I do not know when/how the Changelog is generated but if it is ensured that pre-commit is run after generating it then the Changelog contents will be checked.

@frederic34
Copy link
Member

@mdeweerd thank's, for the changelog see here f12378d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants