CLOSE #26384 Implement STOCK_USE_WAREHOUSE_USAGE for use of non-counting warehouses e.g. quarantine #30199
+59
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting warehouses e.g. quarantine This feature complements the need explained in Dolibarr#26384 and the implementation of the STATUS_OPENEXT_ALL warehouse type. With the changes a warehouse can be used e.g. as a quarantine warehouse or a temporary pre-QC warehouse. The status "Open (omitted from stock calculation)" keeps the definition vague enough as not to constrain the use of this status too much in the sense of "either quarantine or pre-QC". For code-readability and convenience the change is using the load_stock and loadWarehouses implementation. As the option of warehouseclosed, warehouseopen and warehouseinternal is already introduced in the code we can piggyback ride with the introduction of the STATUS_OPENEXT_ALL onto the product list view, stock transfer, delivery selection etc.
…dolibarr into patch-noncounting-stock
eldy
requested changes
Jun 30, 2024
eldy
added
the
PR to fix - See feedback in comments
…non-counting warehouses e.g. quarantine" This reverts commit 0d069b4.
…on-counting warehouses e.g. quarantine This feature implements the global variable of STOCK_USE_WAREHOUSE_USAGE. This variable allows warehouses to exclude their products from stock calculations. A button was added to the stock module in the admin panel. A simple "AND" check for the warehouse_usage column in the entrepot SQL table is added to the load_stock function to facilitate this change.
DaBootO
changed the title
DaBootO
changed the title
3 tasks
|
I am very sorry! I am pretty new to PRs and how my local developments is being reflected in this PR timeline. Sorry for clogging up stuff with all those name changes and pulling the new develop branch from upstream -.- |
|
Thank you for this very good first proposition 👍
|
Thank you very much! I changed the translation keys in the en_US version as to CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE #26384 Implement STATUS_OPENEXT_ALL for use of non-counting warehouses e.g. quarantine
This feature complements the need explained in #26384 and the implementation of the STATUS_OPENEXT_ALL warehouse type. With the changes a warehouse can be used e.g. as a quarantine warehouse or a temporary pre-QC warehouse. The status "Open (omitted from stock calculation)" keeps the definition vague enough as not to constrain the use of this status too much in the sense of "either quarantine or pre-QC".
For code-readability and convenience the change is using the load_stock and loadWarehouses implementation. As the option of warehouseclosed, warehouseopen and warehouseinternal is already introduced in the code we can piggyback ride with the introduction of the STATUS_OPENEXT_ALL onto the product list view, stock transfer, delivery selection etc.