New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract and respond with bytes instead of string #1

Open

cyqsimon wants to merge 1 commit into Dominux:main from cyqsimon:non-text-response-fix

cyqsimon commented Nov 22, 2023

Extracting the body with response.text() causes binary blobs to be erroneously escaped. For example:

$ PORT=8000 cargo run &
$ curl -o original https://github.com/cyqsimon/documented/archive/refs/tags/v0.2.0.tar.gz
$ curl -o proxied http://localhost:8000/https://github.com/cyqsimon/documented/archive/refs/tags/v0.2.0.tar.gz

# the two files should be the same but are not
$ ls -l original proxied
$ md5sums original proxied

By extracting the bytes instead, all kinds of files are correctly passed through.


          Respond with bytes

8ed0c23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet