Add download package to aid in the retrieval of file/files from remote sources #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What can I say? I enjoy the whitespace
shadycuz
added
enhancement
shadycuz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an interface called
FileRetrieverthat for now specifies a single methodvoid retrieve(String url, Path destination).I have created two different classes that implement this interface.
HttpRetrieverwhich downloads a file from an HTTP server andArchiveRetrieverwhich does the same thing but unpacks the tar/zip to thedestination(which would have to be a directory).I had to patch the
Pathlibrary with some additional functionality to implement theArchiveRetriever, but in the future I hope to inline that logic into theArchiveRetriever.