Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support supplying doppler configure set value on stdin #272

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Support supplying doppler configure set value on stdin #272

merged 3 commits into from
Oct 25, 2021

Conversation

Piccirello
Copy link
Contributor

Closes ENG-3346.

@Piccirello Piccirello requested a review from a team October 23, 2021 18:47
nmanoogian
nmanoogian approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@nmanoogian nmanoogian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I did some light local testing with this and everything worked well for me.

@Piccirello Piccirello merged commit 8d7e3b2 into master Oct 25, 2021
@Piccirello Piccirello deleted the configure-set-stdin branch October 25, 2021 21:12
rgmvisser
rgmvisser reviewed Oct 26, 2021
View reviewed changes
tests/e2e/configure.sh
@@ -101,6 +101,13 @@ config="$("$DOPPLER_BINARY" configure get config --configuration=./temp-config -

beforeEach

# test set using stdin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgmvisser rgmvisser rgmvisser left review comments

@nmanoogian nmanoogian nmanoogian approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piccirello @nmanoogian @rgmvisser