Add support for custom managed secret types #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanoogian
force-pushed
the
nic/secret-types
branch
from
aef1784
to
87b375d
Compare
|
Wow at first glance over the changes and doc, this is an amazing change/update. May do exactly what I needed |
seslattery
approved these changes
Aug 14, 2023
Awesome! Thanks for calling those out. I'll make the changes.
Great question -- our tests for the operator are definitely lacking and most of my testing for this change has been manual. I'd love to pick your brain on ways that we could add automated tests for this functionality! |
- Split token secret ref and manage secret ref CRD model types - This allows managed secret ref to supports an optional `type` field - Add `asName` field to processor, allowing for name transformation - Allow processor `type` field to be optional, defaulting to "plain"
nmanoogian
force-pushed
the
nic/secret-types
branch
from
87b375d
to
145f8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom Kubernetes secret types to the operator. The README and docs changes describe the use cases and behavior changes.
Closes ENG-6130