Skip to content

Fixes and improvements #25

Fixes and improvements

Fixes and improvements #25

Triggered via pull request November 26, 2023 11:15
Status Success
Total duration 2m 52s
Artifacts

PullRequest.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

13 warnings
pull_request
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
pull_request: source/DefaultEcs.Test/Serialization/ISerializerTest.cs#L95
Member can be made 'readonly' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0251)
pull_request: source/DefaultEcs.Test/Serialization/ISerializerTest.cs#L99
Member can be made 'readonly' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0251)
pull_request: source/DefaultEcs/Entity.cs#L33
Remove trailing white-space. (http://pihrt.net/roslynator/analyzer?id=RCS1037)
pull_request: source/DefaultEcs/System/Attributes.cs#L100
Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)
pull_request: source/DefaultEcs/Threading/IParallelRunnable.cs#L12
Remove trailing white-space. (http://pihrt.net/roslynator/analyzer?id=RCS1037)
pull_request: source/DefaultEcs/Threading/DefaultParallelRunner.cs#L15
'new' expression can be simplified (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0090)
pull_request: source/DefaultEcs/Entity.cs#L37
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
pull_request: source/DefaultEcs/Resource/AResourceManager.cs#L101
Member can be made 'readonly' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0251)
pull_request: source/DefaultEcs/Resource/AResourceManager.cs#L127
Member can be made 'readonly' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0251)
pull_request: source/DefaultEcs/World.cs#L102
Member can be made 'readonly' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0251)
pull_request: source/DefaultEcs/World.cs#L136
Member can be made 'readonly' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0251)
pull_request: source/DefaultEcs/System/Attributes.cs#L101
Method .ctor passes parameter name 'filterType' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)