Statusor eradication #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- StatusOr<bool> Field::Compare -> bool Field::Compare
TupleDesc::GetFieldType
DorosMichal
approved these changes
Jun 8, 2023
Comment on lines
-90
to
-91
| if (fields.size() <= i || i < 0) { | ||
| return absl::InvalidArgumentError("Index out of range"); |
There was a problem hiding this comment.
Tu chyba możemy zostawić asserta, żeby się od razu wywaliło gdyby jednak nie było in range
Comment on lines
-50
to
-52
| absl::StatusOr<TDItem> TupleDesc::GetItem(int idx) { | ||
| if (!(0 <= idx && idx < items.size())) { | ||
| return absl::InvalidArgumentError("Index out of range"); |
There was a problem hiding this comment.
Tu też bym wszędzie zostawił asserty, bo jak wyjdziemy poza tablicę, ale się nie wywali od razu to to będzie nie do zbugowania
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.