This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Bugfix/acl create #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged with forked remote
|
Checked this against the docs. The consumer is only needed in the url definition not in the body of the call. I think it would be better and still work if the consumer_id property was removed from the ACL Consumer completely and of course references to it. |
Merged
You were totally right. I removed the unneeded parameter from the create function. Also changed to consumer variable in AclConsumer model. Tested with several, list, create and manual acl create. I added these fixes to the branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where ACL plugin 1.0-x is using different create method for ACL's.