added support for XXH3_128 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoumanAsh
reviewed
Mar 25, 2021
src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl XXH3_128 { |
There was a problem hiding this comment.
Move it into the same impl block?
|
I don't mind having it, I was just too lazy because I don't really have need for 128bit hashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick hack to use XXH3_128 streaming struct.
Due to
std::hash::Hasherhas only support forfinish() -> u64, I only removeimpl Hasher for XXH3_128