Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window size flag #14

Closed
andrewbcaldwell opened this issue Mar 15, 2019 · 2 comments
Closed

Add window size flag #14

andrewbcaldwell opened this issue Mar 15, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request to do

Comments

@andrewbcaldwell
Copy link

Would it be possible to add a flag to adjust the window size beyond the standard +/-1500bp? Thanks!

@magruca magruca added enhancement New feature or request to do labels Mar 18, 2019
@magruca
Copy link
Collaborator

magruca commented Mar 18, 2019

This would be easy enough to do and we've toyed the idea of going back and looking at alternative window sizes and alternative window types in general. In our first pass at the MD score analysis (https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5848612/) we found that the majority of published motifs fall within 300bp of the center (mu) of the bidirectional call from using Tfit, thus informing our decision to use the 300/3000bp window centered around the feature of interest.

If you expand the +/-1500, then you also need to expand/adjust the center to keep your background value at 0.1, also easily doable as long as the window is centered. If you start expanding the window too much, however, you'll tend to always just get random noise, quite a bit moreso if you loosen the stringency on your motif scanner.

That said, in future versions, we are probably going to add a few more features to better capture some of the other motif patterns that we see (e.g. RUNX1 has strong co-localization about 500bp+/- offset from the center of a bidirectional), but this again also requires an adjustment as to how the background is calculated.

I'll look into this a little bit more as we've made some adjustments to our processing pipeline for both nascent and ATAC data, but we're probably fine adding a flag for this on the next release.

@magruca magruca self-assigned this Mar 19, 2019
@magruca
Copy link
Collaborator

magruca commented Jul 10, 2019

@andrewbcaldwell -r/--radius argument added in v0.3.0 that will allow you to change the window size. More details are included in the README. Keep in mind, in all of my test cases, this will typically just result in an MD score approaching background (0.1)

@magruca magruca closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to do
Projects
None yet
Development

No branches or pull requests

2 participants