Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge #13

Merged
merged 40 commits into from
Nov 15, 2019
Merged

merge #13

merged 40 commits into from
Nov 15, 2019

Conversation

DrFaust92
Copy link
Owner

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Sunil Kumar Mohanty and others added 30 commits October 13, 2019 11:54
add ca_cert_identifier to rds instance
100fa1f
update documentation
201a0b2
@miguelaferreira @bflad
Fix typo in mq_broker docs (#10888)
861c14a
@teraken0509 @bflad
service/ecs: Refactor to use keyvaluetags package (#10856)
36bb33e 
Output from acceptance testing:

```
--- PASS: TestAccAWSEcsCluster_basic (18.13s)
--- PASS: TestAccAWSEcsCluster_containerInsights (27.54s)
--- PASS: TestAccAWSEcsCluster_disappears (15.45s)
--- PASS: TestAccAWSEcsCluster_Tags (28.54s)
--- PASS: TestAccAWSEcsService_basicImport (84.56s)
--- PASS: TestAccAWSEcsService_disappears (58.00s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (293.66s)
--- PASS: TestAccAWSEcsService_ManagedTags (62.65s)
--- PASS: TestAccAWSEcsService_PropagateTags (135.32s)
--- PASS: TestAccAWSEcsService_Tags (73.95s)
--- PASS: TestAccAWSEcsService_withAlb (251.00s)
--- PASS: TestAccAWSEcsService_withARN (87.87s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (42.23s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (32.69s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (249.69s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (73.21s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (62.75s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (73.02s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (67.27s)
--- PASS: TestAccAWSEcsService_withIamRole (42.25s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (74.39s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (99.98s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (111.66s)
--- PASS: TestAccAWSEcsService_withLbChanges (49.20s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (281.45s)TestAccAWSEcsService_healthCheckGracePeriodSeconds
--- PASS: TestAccAWSEcsService_withPlacementConstraints (54.52s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (42.56s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (234.78s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (112.87s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (63.10s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (142.94s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (132.44s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (62.09s)
--- PASS: TestAccAWSEcsServiceDataSource_basic (74.75s)
--- PASS: TestAccAWSEcsTaskDefinition_arrays (6.78s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (13.05s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (12.53s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (6.87s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (12.16s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (11.15s)
--- PASS: TestAccAWSEcsTaskDefinition_Inactive (12.54s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (8.44s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (17.54s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (7.30s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (6.88s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (47.50s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (10.16s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (10.51s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (10.56s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (6.78s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (10.61s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (7.19s)
```
@ewbankkit @bflad
r/aws_efs_file_system: Support 7-day lifecycle management policy. (#1…
1bde9db 
…0825)

Output from acceptance testing:

```
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (24.74s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (66.07s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (72.03s)
--- PASS: TestAccAWSEFSFileSystem_basic (81.67s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (87.24s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (89.03s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (91.89s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (97.24s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (133.01s)
```
@bflad
Update CHANGELOG for #10825
39cfe25
@mousedownmike @bflad
docs/resource/aws_api_gateway_integration_response: Make response_tem…
dd80bb2 
…plates a map expression (#10617)

Running the current example with terraform 0.12, the plan will fail with "Error: Invalid argument name".  

Changing to a map expression by adding the `=` fixes the error.
@DrFaust92 @bflad
resource/aws_api_gateway_rest_api: Add tags argument and arn attribute (
6389430 
#10581)

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (35.26s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (66.82s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (67.18s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (124.97s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (171.00s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (270.16s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (389.77s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (438.28s)
```
@bflad
Update CHANGELOG for #10581
6bdfa6b
@speller @bflad
Add note for api_gateway_domain_name about implicit dependency on acm…
e8fc2e6 
…_certificate_validation (#10466)
@DrFaust92 @bflad
resource/aws_wafregional_web_acl: add tagging support + read after cr…
e16f1dc 
…eate (#10889)

Output from acceptance testing:

```
--- PASS: TestAccAWSWafRegionalWebAcl_createGroup (40.08s)
--- PASS: TestAccAWSWafRegionalWebAcl_noRules (45.42s)
--- PASS: TestAccAWSWafRegionalWebAcl_basic (68.12s)
--- PASS: TestAccAWSWafRegionalWebAcl_disappears (69.11s)
--- PASS: TestAccAWSWafRegionalWebAcl_changeRules (70.15s)
--- PASS: TestAccAWSWafRegionalWebAcl_tags (70.33s)
--- PASS: TestAccAWSWafRegionalWebAcl_changeDefaultAction (76.21s)
--- PASS: TestAccAWSWafRegionalWebAcl_createRateBased (85.54s)
--- PASS: TestAccAWSWafRegionalWebAcl_changeNameForceNew (96.30s)
--- PASS: TestAccAWSWafRegionalWebAcl_LoggingConfiguration (110.31s)
```
@bflad
Update CHANGELOG for #10889
0166daa
@DrFaust92 @bflad
Add import support for aws_waf_geo_match_set resource (#10480)
4bcbb6e 
Output from acceptance testing:

```
--- PASS: TestAccAWSWafGeoMatchSet_disappears (11.70s)
--- PASS: TestAccAWSWafGeoMatchSet_noConstraints (22.92s)
--- PASS: TestAccAWSWafGeoMatchSet_changeNameForceNew (30.62s)
--- PASS: TestAccAWSWafGeoMatchSet_changeConstraints (41.17s)
--- PASS: TestAccAWSWafGeoMatchSet_basic (44.38s)
```
@bflad
Update CHANGELOG for #10480
256099f
@DrFaust92 @bflad
Add import support for aws_waf_regex_match_set resource (#10481)
f598e22 
Output from acceptance testing:

```
--- PASS: TestAccAWSWafRegexMatchSet (74.73s)
```
@bflad
Update CHANGELOG for #10481
c10f705
@DrFaust92 @bflad
Add import support for aws_waf_regex_pattern_set resource (#10482)
e4864de 
Output from acceptance testing:

```
--- PASS: TestAccAWSWafRegexPatternSet (56.62s)
```
@bflad
Update CHANGELOG for #10482
51c3f1a
@DrFaust92 @bflad
Add import support for aws_waf_size_constraint_set resource (#10484)
428699f 
Output from acceptance testing:

```
--- PASS: TestAccAWSWafSizeConstraintSet_noConstraints (13.57s)
--- PASS: TestAccAWSWafSizeConstraintSet_disappears (21.97s)
--- PASS: TestAccAWSWafSizeConstraintSet_basic (25.21s)
--- PASS: TestAccAWSWafSizeConstraintSet_changeConstraints (29.52s)
--- PASS: TestAccAWSWafSizeConstraintSet_changeNameForceNew (54.31s)
```
@bflad
Update CHANGELOG for #10484
f768e98
@DrFaust92 @bflad
Add support import for aws_waf_xss_match_set resource (#10485)
862ba1c 
Output from acceptance testing (test failure unrelated):

```
--- PASS: TestAccAWSWafXssMatchSet_noTuples (18.48s)
--- FAIL: TestAccAWSWafXssMatchSet_changeTuples (20.84s)
--- PASS: TestAccAWSWafXssMatchSet_basic (27.02s)
--- PASS: TestAccAWSWafXssMatchSet_changeNameForceNew (39.22s)
--- PASS: TestAccAWSWafXssMatchSet_disappears (44.35s)
```
@bflad
Update CHANGELOG for #10485
c3aceb1
@bflad
Update CHANGELOG entries for #10480, #10481, #10482, #10484, and #10485…
8d94da1 
… to include arn attribute addition
@bflad
Merge branch 'ca_cert_identifier' of ssh://github.com/sunilkumarmohan…
fb2c961 
…ty/terraform-provider-aws into sunilkumarmohanty-ca_cert_identifier
@bflad
service/secretsmanager: Refactor tagging logic to keyvaluetags package (
43ae107 
#10745)

Reference: #10688

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Basic (5.99s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (13.99s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (14.02s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_ARN (15.28s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Policy (16.05s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Name (16.35s)
--- PASS: TestAccAwsSecretsManagerSecret_policy (17.75s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (21.89s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (38.69s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (39.41s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (50.42s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (50.55s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (53.23s)
```
@DrFaust92 @bflad
Add import support for aws_wafregional_web_acl_association resource (#…
39ec0b6 
…10538)

Output from acceptance testing:

```
--- PASS: TestAccAWSWafRegionalWebAclAssociation_ResourceArn_ApiGatewayStage (44.37s)
--- PASS: TestAccAWSWafRegionalWebAclAssociation_disappears (185.89s)
--- PASS: TestAccAWSWafRegionalWebAclAssociation_basic (192.13s)
--- PASS: TestAccAWSWafRegionalWebAclAssociation_multipleAssociations (194.36s)
```
@bflad
Update CHANGELOG for #10538
b964f34
@bflad
service/transfer: Refactor tagging logic to keyvaluetags package (#10739
b689da3 
)

Reference: #10688

Output from acceptance testing:

```
--- PASS: TestAccAWSTransferUser_UserName_Validation (5.86s)
--- PASS: TestAccAWSTransferServer_disappears (11.20s)
--- PASS: TestAccAWSTransferUser_disappears (14.61s)
--- PASS: TestAccAWSTransferServer_forcedestroy (15.39s)
--- PASS: TestAccAWSTransferUser_basic (16.12s)
--- PASS: TestAccAWSTransferServer_apigateway (20.54s)
--- PASS: TestAccAWSTransferServer_basic (21.48s)
--- PASS: TestAccAWSTransferUser_modifyWithOptions (36.18s)
--- PASS: TestAccAWSTransferServer_vpcEndpointId (77.08s)
```
@bflad
resource/aws_sns_topic: Refactor tagging logic to use keyvaluetags pa…
2a8e6d4 
…ckage and call Read after Create (#10741)

Reference: #10688

Output from acceptance testing:

```
--- PASS: TestAccAWSSNSTopic_name (13.72s)
--- PASS: TestAccAWSSNSTopic_namePrefix (13.88s)
--- PASS: TestAccAWSSNSTopic_basic (14.02s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (14.52s)
--- PASS: TestAccAWSSNSTopic_policy (14.77s)
--- PASS: TestAccAWSSNSTopic_encryption (22.23s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (22.35s)
--- PASS: TestAccAWSSNSTopic_tags (30.82s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (31.95s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (129.10s)
```
@bflad
service/sfn: Refactor tagging logic to keyvaluetags package (#10744)
7fa6438 
Output from acceptance testing (failure unrelated and present on master):

```
--- PASS: TestAccAWSSfnActivity_basic (12.40s)
--- PASS: TestAccAWSSfnActivity_Tags (38.16s)
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (39.18s)
    testing.go:615: Step 1 error: Check failed: Check 5/6 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws:lambda:us-west-2:--OMITTED--:function:sfn-ls0gr71fnj\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\"States.ALL\"],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8.0\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"
--- PASS: TestAccAWSSfnStateMachine_Tags (56.24s)
```
ewbankkit and others added 10 commits November 15, 2019 14:52
@ewbankkit @bflad
resource/aws_s3_bucket_inventory: Add support for 'IntelligentTiering…
581cc79 
…AccessTier'. (#10746)

Output from acceptance testing:

```
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (27.93s)
--- PASS: TestAccAWSS3BucketInventory_basic (29.30s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (50.53s)
```
@bflad
Update CHANGELOG for #10746
0c0f604
@bflad
Merge branch 'sunilkumarmohanty-ca_cert_identifier'
16cdb71
@bflad
Update CHANGELOG for #10490
17c05f5
@DrFaust92 @bflad
r/aws_wafregional_rule - add tagging support + expose arn + read afte…
d757599 
…r create (#10895)

Output from acceptance testing:

```
--- PASS: TestAccAWSWafRegionalRule_disappears (36.53s)
--- PASS: TestAccAWSWafRegionalRule_noPredicates (39.85s)
--- PASS: TestAccAWSWafRegionalRule_tags (46.46s)
--- PASS: TestAccAWSWafRegionalRule_changePredicates (72.39s)
--- PASS: TestAccAWSWafRegionalRule_changeNameForceNew (74.27s)
--- PASS: TestAccAWSWafRegionalRule_basic (92.20s)
```
@bflad
Update CHANGELOG for #10895
ce8745c
@DrFaust92 @bflad
r/aws_wafregional_rule_group - add tagging support + expose arn + rea…
91a6c37 
…d after create (#10896)

Output from acceptance testing:

```
--- PASS: TestAccAWSWafRegionalRuleGroup_noActivatedRules (16.87s)
--- PASS: TestAccAWSWafRegionalRuleGroup_tags (35.24s)
--- PASS: TestAccAWSWafRegionalRuleGroup_disappears (36.43s)
--- PASS: TestAccAWSWafRegionalRuleGroup_changeNameForceNew (38.47s)
--- PASS: TestAccAWSWafRegionalRuleGroup_changeActivatedRules (45.89s)
--- PASS: TestAccAWSWafRegionalRuleGroup_basic (48.20s)
```
@bflad
Update CHANGELOG for #10896
0760e61
@DrFaust92 @bflad
add tagging support for waf regional rate base rule resource (#10897)
58032fa 
Output from acceptance testing:

```
--- PASS: TestAccAWSWafRegionalRateBasedRule_noPredicates (16.12s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changeRateLimit (18.16s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_tags (59.44s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changeNameForceNew (63.98s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_basic (65.44s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changePredicates (73.59s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_disappears (74.58s)
```
@bflad
Update CHANGELOG for #10897
12b40de
@DrFaust92 DrFaust92 merged commit 44defd1 into DrFaust92:master Nov 15, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@DrFaust92 @miguelaferreira @teraken0509 @ewbankkit @bflad @mousedownmike @speller