Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning off SPEX python interface #805

Merged
merged 10 commits into from
May 23, 2024

Conversation

rayegun
Copy link
Contributor

@rayegun rayegun commented May 20, 2024

There's currently no way to turn this off when building shared libs, and it would be cleanest to allow turning it off at the SuiteSparse level, not just the SPEX level.

dependabot bot and others added 7 commits April 22, 2024 19:44
Bumps [Jimver/cuda-toolkit](https://github.com/jimver/cuda-toolkit) from 0.2.14 to 0.2.15.
- [Release notes](https://github.com/jimver/cuda-toolkit/releases)
- [Commits](Jimver/cuda-toolkit@v0.2.14...v0.2.15)

---
updated-dependencies:
- dependency-name: Jimver/cuda-toolkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ependabot/github_actions/Jimver/cuda-toolkit-0.2.15

Bump Jimver/cuda-toolkit from 0.2.14 to 0.2.15
Bumps [Jimver/cuda-toolkit](https://github.com/jimver/cuda-toolkit) from 0.2.14 to 0.2.15.
- [Release notes](https://github.com/jimver/cuda-toolkit/releases)
- [Commits](Jimver/cuda-toolkit@v0.2.14...v0.2.15)

---
updated-dependencies:
- dependency-name: Jimver/cuda-toolkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ependabot/github_actions/Jimver/cuda-toolkit-0.2.15

Bump Jimver/cuda-toolkit from 0.2.14 to 0.2.15
@mmuetzel
Copy link
Contributor

Looks good to me.

Should the new CMake parameter be named SUITESPARSE_USE_PYTHON (or SUITESPARSE_ENABLE_PYTHON) to better fit the naming convention that is being used for recent changes?

@rayegun
Copy link
Contributor Author

rayegun commented May 21, 2024

Good point, updated the naming

@mmuetzel
Copy link
Contributor

It would probably be nice to document the new variable. Maybe, around here?

* `SUITESPARSE_USE_OPENMP`:

@DrTimothyAldenDavis
Copy link
Owner

yes, adding something to the top-level README would be a good idea. Also in the SPEX/README.

I have some other changes to SPEX that are pending, in the paru_dev2 branch. I'm making some major changes to ParU in that branch, and while I was working on that I found some issues with SPEX when building the MATLAB interface. I'll rebase this to the paru_dev2 branch and merge it there.

Then I, or @rayegun, could add the README updates to paru_dev2.

Alternatively, I could do a PR of paru_dev2 into dev2, but I'm hesitant to do that just now without resolving some of the other PRs to dev2 just now.

@DrTimothyAldenDavis DrTimothyAldenDavis changed the base branch from dev to paru_dev2 May 23, 2024 12:14
@DrTimothyAldenDavis DrTimothyAldenDavis changed the base branch from paru_dev2 to dev2 May 23, 2024 12:15
@DrTimothyAldenDavis
Copy link
Owner

DrTimothyAldenDavis commented May 23, 2024

Correction: I'll go ahead and merge this into dev2 and then keep paru_dev2 updated with PRs from dev2 to paru_dev2. Less churn that way.

Also: I will rename this as SUITESPARSE_USE_PYTHON since the _USE_ style is used for all other options like this one.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 5f8a439 into DrTimothyAldenDavis:dev2 May 23, 2024
25 checks passed
@DrTimothyAldenDavis
Copy link
Owner

DrTimothyAldenDavis commented May 23, 2024

Updated with this commit:

8d59151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants