-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow turning off SPEX python interface #805
Allow turning off SPEX python interface #805
Conversation
Bumps [Jimver/cuda-toolkit](https://github.com/jimver/cuda-toolkit) from 0.2.14 to 0.2.15. - [Release notes](https://github.com/jimver/cuda-toolkit/releases) - [Commits](Jimver/cuda-toolkit@v0.2.14...v0.2.15) --- updated-dependencies: - dependency-name: Jimver/cuda-toolkit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ependabot/github_actions/Jimver/cuda-toolkit-0.2.15 Bump Jimver/cuda-toolkit from 0.2.14 to 0.2.15
Bumps [Jimver/cuda-toolkit](https://github.com/jimver/cuda-toolkit) from 0.2.14 to 0.2.15. - [Release notes](https://github.com/jimver/cuda-toolkit/releases) - [Commits](Jimver/cuda-toolkit@v0.2.14...v0.2.15) --- updated-dependencies: - dependency-name: Jimver/cuda-toolkit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ependabot/github_actions/Jimver/cuda-toolkit-0.2.15 Bump Jimver/cuda-toolkit from 0.2.14 to 0.2.15
Looks good to me. Should the new CMake parameter be named |
Good point, updated the naming |
It would probably be nice to document the new variable. Maybe, around here?
|
yes, adding something to the top-level README would be a good idea. Also in the SPEX/README. I have some other changes to SPEX that are pending, in the paru_dev2 branch. I'm making some major changes to ParU in that branch, and while I was working on that I found some issues with SPEX when building the MATLAB interface. I'll rebase this to the paru_dev2 branch and merge it there. Then I, or @rayegun, could add the README updates to paru_dev2. Alternatively, I could do a PR of paru_dev2 into dev2, but I'm hesitant to do that just now without resolving some of the other PRs to dev2 just now. |
Correction: I'll go ahead and merge this into dev2 and then keep paru_dev2 updated with PRs from dev2 to paru_dev2. Less churn that way. Also: I will rename this as |
5f8a439
into
DrTimothyAldenDavis:dev2
Updated with this commit: |
There's currently no way to turn this off when building shared libs, and it would be cleanest to allow turning it off at the SuiteSparse level, not just the SPEX level.