Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sound output terminal functions #26

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Added sound output terminal functions #26

merged 1 commit into from
Jan 30, 2024

Conversation

696GrocuttT
Copy link
Contributor

The sound output functions allow the user to control whether the internal TV speakers are used or whether an external destination like an AV receiver is the target.

Drafteed
Drafteed reviewed Jan 26, 2024
View reviewed changes
Copy link
Owner

@Drafteed Drafteed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

Let's rename the functions to get_sound_settings and set_sound_settings to match the name in the official API.
Also please fix the formatting.

Drafteed
Drafteed reviewed Jan 26, 2024
View reviewed changes
pybravia/client.py Outdated Show resolved Hide resolved
@Drafteed
Copy link
Owner

Drafteed commented Jan 30, 2024 •
edited
Loading

Thanks, @696GrocuttT 👍

@Drafteed Drafteed merged commit 93df39e into Drafteed:master Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drafteed Drafteed Drafteed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@696GrocuttT @Drafteed