-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meaningful constants #86
Comments
Moreover, the listEuropeanCountries function should not return 'EU' as a european country code IMO, regardless of what the constant is called. |
@Seldaek yes the listEuropeanCountries should not return EU. We could do this two ways
I think we should go with option 1) since probably (don't know why it's not working this way now) VIES will allow to validate EU MOSS VAT numbers in the near future, and we will just need to rewrite the ValidateEU class to make it work. |
@Seldaek Could You fix the PHPCS errors so we could merge it and release it #87 (comment) |
Closing this issue as PR #87 is now integrated in master code and will be released soon. |
When we first started out creating this service, we only looked at validation of VAT ID's for EU countries and named our constants in such a way that we weren't ready for other validation types.
Now with issue #82 a new type of validation was presented for companies outside of EU that require a VAT ID to perform business within the EU. We have implemented this validation already in PR #85 but the naming convention of the constants
VIES_EU_COUNTRY_TOTAL
andVIES_EU_COUNTRY_LIST
no longer represent their true values.These constants require to be changed into a more meaningful label that reflects this new situation.
The text was updated successfully, but these errors were encountered: