Issue #99: Problems validating non-Latin trader values #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit I changed the way we're filtering and validating characters so that we allow non-Latin characters as we have in Germany, Poland, Greece and other countries.
After some discussion on issue #99 I improved the way we filter arguments, especially for trader company names and added a couple of additional test cases to make sure we allow special characters inside the trader names.
For Spain the full trader details are required and cannot be filtered before validation, therefor we need to add these characters to the whitelist. Not really an ideal situation, but we improve over time.
DragonBe
added a commit
that referenced
this pull request
May 27, 2020
Fixes #99 and closes PR #100 with many thanks to @robmeek and @fidelo-software for giving me their feedback. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #99: In this commit I changed the way we're filtering and validating characters so that we allow non-Latin characters as we have in Germany, Poland, Greece and other countries.