u3d/list: display full revision number (prepares for #274) #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
commented
Apr 19, 2018
| @@ -163,6 +167,39 @@ def plist | |||
| end | |||
| end | |||
|
|
|||
| class LinuxInstallationHelper | |||
| STRINGS_FULL_VERSION_MATCHER = /^[0-9\.abfp]+_[0-9a-f]{12}/ | |||
There was a problem hiding this comment.
Here I would have to check if we get weird values, e.g. with some of the versions that had weird build numbers.
|
It works nicely on Windows :) |
niezbop
approved these changes
Apr 19, 2018
| @@ -176,6 +213,10 @@ def version | |||
| version | |||
| end | |||
|
|
|||
| def build_number | |||
| @build_number ||= LinuxInstallationHelper.new.find_build_number(root_path) | |||
There was a problem hiding this comment.
Maybe we could make the find_build_number a class method rather than an instance? It would make a bit more sense to me. Especially given the fact that the Helper doesn't carry any sort of data so all of its current methods could be moved to self?
There was a problem hiding this comment.
I was trying to avoid class methods! I don't find them particularly elegant from an API point of view. Thoses classes are meant internal though, not part of the public API in my mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
bundle exec rspecto make sure that my PR didn't break any testbundle exec rubocopto make sure that my PR is inline with our code stylePull Request Description
Tested on Linux/Windows/Mac on the computers I had access to, would need slightly more testing to make sure Unity doesn't do weird things with special builds. So adding the feature as part of
listto test it a bit more.We need to work a bit more on the overall feature set to see how to solve #274
Mac:
Linux:
Windows:
Meh... believe me it worked.