[CCXTExchange] Add headers and options attribute #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
force-pushed
the
feature/add-options-and-headers-attributes
branch
from
8e39378
to
fafa811
Compare
Herklos
force-pushed
the
feature/add-options-and-headers-attributes
branch
from
fafa811
to
915450f
Compare
| :param options_dict: the additional option keys and values as dict | ||
| """ | ||
| for option_key in options_dict.keys(): | ||
| self.options[option_key] = options_dict[option_key] |
There was a problem hiding this comment.
for option_key, option_value in options_dict.items():
self.options[option_key] = option_value| for option_key in options_dict.keys(): | ||
| self.options[option_key] = options_dict[option_key] | ||
| if self.client is not None: | ||
| self.client.options[option_key] = options_dict[option_key] |
There was a problem hiding this comment.
self.client.options[option_key] = option_value
There was a problem hiding this comment.
that means that self.client might only have some of the exchange option if it is set later ? maybe we should add every option all the time (to be sure it's always a mirror). Or upon creation all options are always passed ?
| Add new headers to ccxt client | ||
| :param headers_dict: the additional header keys and values as dict | ||
| """ | ||
| for header_key in headers_dict.keys(): |
There was a problem hiding this comment.
for header_key header_value in headers_dict.idems():
Herklos
force-pushed
the
feature/add-options-and-headers-attributes
branch
from
915450f
to
fd72287
Compare
GuillaumeDSM
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.