[RestExchange] filter symbols depending on exchange type #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if octobot_commons.SETTLEMENT_ASSET_SEPARATOR not in symbol} | ||
| elif self.exchange_manager.is_future: | ||
| return {symbol for symbol in self.connector.symbols | ||
| if octobot_commons.SETTLEMENT_ASSET_SEPARATOR in symbol} |
There was a problem hiding this comment.
Good idea !
I think it would be better to use parse_symbol(symbol).is_future() and parse_symbol(symbol).is_spot()
There was a problem hiding this comment.
oh yeah looks better, I changed it
techfreaque
force-pushed
the
filter_symbols
branch
from
65101f8
to
3b5e644
Compare
techfreaque
force-pushed
the
filter_symbols
branch
from
3b5e644
to
b7ebfdd
Compare
Herklos
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure a spot exchange will only run on a spot pair and a futures pair only on futures