Fix incomplete keyset when there are no keypairs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are no keypairs and Keypair.keyset is called twice sequentially, it will create keypairs on both calls. Additionally, in the first call it will not return the future keypair, resulting in only one keypair being returned. Only on the second call of Keypair.keyset will a future keypair also be returned.
StefSchenkelaars
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are no keypairs and
Keypair.keysetis called twice sequentially, it will create keypairs on both calls. Additionally, in the first call it will not return the future keypair, resulting in only one keypair being returned. Only on the second call ofKeypair.keysetwill a future keypair also be returned.This fixes it by simply making it a
whileloop, so two keypairs are created on a first call ofKeypair.keyset.