Fix mismatch between sort and used fields in Keypair.keyset #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valid keys of a keypair were sorted on
expires_at
, but for determining the validity of the keys it usesnot_before
. Therefore, when theexpires_at
of a keypair did not exactly match the default rotation period, there could be a mismatch between the actual future key, and the key that was used for checking whether there was a future key.This fixes the use case of creating one keypair for development which does not rotate by manually setting the
not_after
andexpires_at
(as in the spec).