Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch between sort and used fields in Keypair.keyset #4

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

koesie10
Copy link
Contributor

The valid keys of a keypair were sorted on expires_at, but for determining the validity of the keys it uses not_before. Therefore, when the expires_at of a keypair did not exactly match the default rotation period, there could be a mismatch between the actual future key, and the key that was used for checking whether there was a future key.

This fixes the use case of creating one keypair for development which does not rotate by manually setting the not_after and expires_at (as in the spec).

The valid keys of a keypair were sorted on expires_at, but for determining
the validity of the keys it uses not_before. Therefore, when the expires_at
of a keypair did not exactly match the default rotation period, there could
be a mismatch between the actual future key, and the key that was used for
checking whether there was a future key.
@StefSchenkelaars StefSchenkelaars merged commit c904056 into main Nov 15, 2021
@StefSchenkelaars StefSchenkelaars deleted the fix/sort-on-not-before branch November 15, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants