238 put options for the dropdown in their own type #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to try help use the Elm type system to make the code more clear and hopefully avoid some bugs.
I'm not sure this PR actually fixes any bugs but I do feel like this is an improvement.
There are a lot of places in Much Select where we have a list of options. In some cases we actually know more about that list of options then that it's just a list of options.
There are several places in MuchSelect where we need to know which options are in the drop drown. Once we have that figured out, we could "capture" that bit of information and "encode" it in a type. This PR adds types for that.
I ended up having to add a couple of types because we also group options (think the
<optgroup>tag).These changes should make working on #141 and easier and safer goal.