custom selected options always get a selected value index of 0 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the selected value index of 0. To fix this I had to change up some of the logic and that broke some unit tests having to do with merging options. I think I solved by by making the `selectOptions` function a bit more complicated. It's behavior seems pretty sensible so I think it's OK. But I can't help but wonder if the options that are coming in to be selected should already have a selected index on them.
jachin
changed the title
jachin
changed the title
jachin
deleted the
244-custom-options-jump-to-the-front-of-the-selected-items
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix this I had to change up some of the logic and that broke some unit tests having to do with merging options. I think I solved by by making the
selectOptionsfunction a bit more complicated. It's behavior seems pretty sensible so I think it's OK.But I can't help but wonder if the options that are coming in to be selected should already have a selected index on them.