Make the release automatic #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been almost done but publisher-keys.json doesn't work well because of the authorization issue 🙇 I'll ask to the member who is the owner account. |
Merged
# Conflicts: # .circleci/config.yml
|
Finally, it works! |
|
🎉 |
takahirom
reviewed
Feb 6, 2018
| @@ -251,6 +251,19 @@ SessionsFragment.kt | |||
| }) | |||
| ``` | |||
|
|
|||
| ## Release | |||
takahirom
reviewed
Feb 6, 2018
| @@ -0,0 +1,7 @@ | |||
| 2018年2月8・9日に開催予定の DroidKaigi 2018 の公式アプリです。セッションのスケジュール確認や当日のお供にお使いください。 | |||
There was a problem hiding this comment.
Will English descriptions are deleted? 🤔
There was a problem hiding this comment.
Ah, you have already added it?
I'll add en/listing.
There was a problem hiding this comment.
👍 But I can't find English whatsnew in Google Play console.
Can you create it later?
There was a problem hiding this comment.
Well..
ついにDroidKaigiも今週になりましたね！
見に行くセッションは決まってきましたか？
公式アプリはまだまだコントリビューターのみなさんの修正を受け付けております！
開始時間ごとにセッションが見やすくなりました。
お知らせを通知するようになりました。
Google translated..
At last DroidKaigi got this week!
Have you decided on sessions to go see?
The official application is still accepting contributors' contributions!
The session became easier to see at each start time.
I now notify you of notifications.
There was a problem hiding this comment.
お待たせしました！
DroidKaigi is finally upon us!
Have you decided which sessions you want to see?
The official app is still accepting contributions!
Changes:
Its now easier to see when each session starts
Information will now be sent as push notifications
でどうでしょうか！
There was a problem hiding this comment.
Thanks! I added English metadata.
Can you review again?
|
Thanks Let's merge this🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)