Don't force consumers to use jetifier #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vudzkostek
force-pushed
the
legacy_appcompat
branch
from
85a7832
to
412d36e
Compare
koral--
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taki mój pomysł na rozwiązanie problemu w CCC.
NIE WIEM CZY NA 100% TO ROZWIĄŻE PROBLEM.
Nie wiem czy najlesze podejście ale dla FoQA taki jetifier nie jest jakimś spowalniaczem i dzięki tej zmianie potrzebna zależność już bedzie przerobiona na androidX przez co projekty używające FoQA nie będą musiały tego robić.
Może jest jakaś nowsza biblioteka którą możnaby zastąpić problematyczną zależność ale nie mam teraz możliwości i czasu żeby szukać a przede wszystkim wdrażać się w projekt żeby dobrze zmigrować na nową libkę 🤷