Add storage info and no retry policy to share uploader #55
Conversation
|
Ref DroneDB/DDB.js#3 |
HeDo88TH
changed the title
package.json
Outdated
| @@ -19,7 +19,10 @@ | |||
| "dependencies": { | |||
| "commonui": "file:vendor/commonui", | |||
| "copy-webpack-plugin": "^6.4.0", | |||
| "portal-vue": "^2.1.7", | |||
| "semantic-ui-vue": "^0.11.0", | |||
There was a problem hiding this comment.
Can we not add this? This package is not maintained and adds a lot of space just for displaying a popup.
There was a problem hiding this comment.
I am using the popup component only. It works well and thanks to tree shaking It does not even add any meaningful weight to the web app:
webpack --mode=production
without library:
main.js 1.4MB (2.9MB)
with library:
main.js 1.4MB (3.0MB)
The first size is the compressed size transferred in the browser and the last is the uncompressed size.
I take full responsibility for this component: if it breaks I will re-write it from scratch 👍
It also packs a lot of useful Semantic components for Vue that may be useful in the future!
There was a problem hiding this comment.
👎
You already have a modal setting from the Window component.
There was a problem hiding this comment.
Changed in 00f82f4
|
Dependencies are still in |
…to add-storage-info
|
Responsive behaviour is fixed in 5f40d9c |
Added storage info popup