undef tests and docs for undef/non-numeric arg handling #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
reviewed
Jan 5, 2018
| local $SIG{__WARN__} = sub { $warning = shift }; | ||
|
|
||
| my $var = dualvar(undef, undef); | ||
| like($warning, qr/Use of uninitialized value in subroutine entry/, 'undef arg warning'); |
There was a problem hiding this comment.
Aren't these warnings localised to different languages? Or am I being confused about $! ?
leonerd
reviewed
Jan 5, 2018
| ok( $var == undef, 'Numeric value'); | ||
| ok( $var eq undef, 'String value'); | ||
|
|
||
| my $var2 = dualvar(2.2, undef); |
There was a problem hiding this comment.
You probably want to
undef $warning;
just before each additional test block to ensure that it's not just remaining from the previous
leonerd
reviewed
Jan 5, 2018
| local $SIG{__WARN__} = sub { $warning = shift }; | ||
|
|
||
| my @c = prototype(); | ||
| is( scalar @c, 0, 'no arg results in empty list'); # XXX |
There was a problem hiding this comment.
Inconsistent whitespacing - probably wants to be
is(scalar @c, 0, 'no arg results in empty list'); # XXX
leonerd
reviewed
Jan 5, 2018
| like($warning, qr/Use of uninitialized value in subroutine prototype/, 'no arg results in undef arg warning'); | ||
| undef $warning; | ||
|
|
||
| is( prototype(undef), undef, 'undef arg'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for https://rt.cpan.org/Ticket/Display.html?id=121013 and still requires some feedback.