Example of breaking PlmgButton component #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit ad45a5f): https://test-auth-d13f2--pr53-buttonissue-rhkiixm0.web.app (expires Wed, 22 Jun 2022 11:15:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Oh man! That's a shame 🤦 Indead, changing the button to Shadow DOM fixes it. Arguably the button does not really need a slot, a viable fix is to use a "text" property instead. (see commit ad45a5f) |
|
Thanks for the example, closing this issue in favor of the Asana task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not meant as a PR, but a repro of an issue
The issue
Investigation