Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Antiforgery correctly #158

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

programatt
Copy link
Contributor

What issue does this PR address?
Mispelling of Antiforgery in the Interface Name

Important: Any code or remarks in your Pull Request are under the following terms:

If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.

(see our license, section 7)

@brockallen
Copy link
Member

Oh that's a bummer. Well, thanks for this, but given that the type name needs changing, we will need to hold off on this until a new release. We'll leave this open until we can figure out when that will be.

Thanks again.

@brockallen brockallen added this to the 2.1.0 milestone Feb 9, 2023
@brockallen brockallen added the bug label Feb 9, 2023
@brockallen
Copy link
Member

Ok, given that one one should be using this directly then we decided that it's likely safe to do this now. Thanks!

@brockallen brockallen merged commit 720a0f5 into DuendeSoftware:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants