Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return successfully deserialized grants even if some fail #1506

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Return successfully deserialized grants even if some fail #1506

merged 2 commits into from
Jan 5, 2024

Conversation

AndersAbel
Copy link
Member

Fixes #1479

@josephdecock josephdecock changed the title Return successfully deserialized grants even if some fails Return successfully deserialized grants even if some fail Jan 4, 2024
@AndersAbel AndersAbel marked this pull request as ready for review January 4, 2024 20:14
josephdecock
josephdecock reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would have a test for these changes.

@josephdecock josephdecock added this to the 7.0.0 milestone Jan 4, 2024
@josephdecock josephdecock added the enhancement New feature or request label Jan 4, 2024
@brockallen brockallen modified the milestones: 7.0.0, 6.3.8 Jan 5, 2024
@brockallen brockallen merged commit 6012c36 into releases/6.3.x Jan 5, 2024
3 checks passed
@brockallen brockallen deleted the anders/1479_GetAllUserGrantsAsync branch January 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephdecock josephdecock josephdecock approved these changes

@brockallen brockallen Awaiting requested review from brockallen

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
6.3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@AndersAbel @josephdecock @brockallen