Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe WithOptionalUserAccessToken for BFF yarp #308

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Describe WithOptionalUserAccessToken for BFF yarp #308

merged 4 commits into from
Jul 7, 2023

Conversation

josephdecock
Copy link
Member

Resolves #307

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-308.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-308.eastus2.azurestaticapps.net

@brockallen
Copy link
Member

Is there anywhere else that we need to indicate that the other API requires some token?

@josephdecock
Copy link
Member Author

Is there anywhere else that we need to indicate that the other API requires some token?

That's a good point. I've added a bit to the section on WithAccessToken to say that it requires the token.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-308.eastus2.azurestaticapps.net

@josephdecock
Copy link
Member Author

I also realized that I wasn't showing how to get an optional token using metadata. I've added that now, so this is ready for review @brockallen.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-308.eastus2.azurestaticapps.net

@josephdecock josephdecock mentioned this pull request Jul 7, 2023
Closed
@brockallen brockallen merged commit 297a805 into main Jul 7, 2023
@brockallen brockallen deleted the joe/optional-user-access-token-yarp branch July 7, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brockallen brockallen brockallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BFF YARP WithOptionalAccessToken
2 participants
@josephdecock @brockallen