Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading doctrine/orm v2 to v3 #49

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

evertharmeling
Copy link

Made a start on upgrading to doctrine/orm^3.0

Done

  • Replaced Lexer with TokenType
      • Made classes consistent in order of methods in FunctionNode (getSql() first)

Todo

1) DoctrineExtensions\Tests\Query\Mysql\DateTest::testDateDiff
Doctrine\DBAL\Exception: Unknown column type "DateTime" requested. Any Doctrine type that you use has to be registered with \Doctrine\DBAL\Types\Type::addType(). You can get a list of all the known types with \Doctrine\DBAL\Types\Type::getTypesMap(). If this error occurs during database introspection then you might have forgotten to register all database types for a Doctrine Type. Use AbstractPlatform#registerDoctrineTypeMapping() or have your custom types implement Type#getMappedDatabaseTypes(). If the type name is empty you might have a problem with the cache or forgot some mapping information.
  • Currently the suite has 15 errors like above, maybe more come if the error is fixed

Not sure what is causing and how to fix this error...

Reproduce error

Run composer test

If someone has a clue, feel free to takeover the PR or add commits

@Chris53897 Chris53897 mentioned this pull request Nov 18, 2023
@Chris53897
Copy link

@evertharmeling
Thanks for the PR.

Please see #50
Can you please rebase against master and remove the draft state?

I guess CI will be green in next run.

@evertharmeling
Copy link
Author

Done!

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (5bebc28) 89.48% compared to head (1e0a5b8) 89.48%.

Files Patch % Lines
src/Query/Mysql/AesDecrypt.php 0.00% 7 Missing ⚠️
src/Query/Mysql/AesEncrypt.php 0.00% 7 Missing ⚠️
src/Query/Mysql/FromBase64.php 0.00% 7 Missing ⚠️
src/Query/Mysql/NullIf.php 0.00% 7 Missing ⚠️
src/Query/Mysql/AnyValue.php 0.00% 5 Missing ⚠️
src/Query/Oracle/Nvl.php 0.00% 4 Missing ⚠️
src/Query/Oracle/ToDate.php 0.00% 4 Missing ⚠️
src/Query/Mysql/ConcatWs.php 84.21% 3 Missing ⚠️
src/Query/Mysql/Date.php 0.00% 3 Missing ⚠️
src/Query/Mysql/SecToTime.php 0.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #49   +/-   ##
=========================================
  Coverage     89.48%   89.48%           
  Complexity      556      556           
=========================================
  Files           192      192           
  Lines          2292     2292           
=========================================
  Hits           2051     2051           
  Misses          241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chris53897
Copy link

Thanks, i will merge it and fix the php cs fixer warnings later on.

@Chris53897 Chris53897 merged commit 81b80a3 into Dukecity:master Nov 20, 2023
4 of 6 checks passed
@evertharmeling
Copy link
Author

Yw, thanks for the quick response!

@laurentmuller
Copy link

laurentmuller commented Feb 22, 2024

Hello,

This plugin is the last I use that need version 2.0. Any plan to release a new version with ORM 3.0 ?

Thanks

@Chris53897
Copy link

Hi @laurentmuller
I just created #52
Please have a look. We can merge some of the changes from the orginal repo into this one.
But i suggest to wait until doctrine/orm 2.19 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants