-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading doctrine/orm v2 to v3 #49
Conversation
@evertharmeling Please see #50 I guess CI will be green in next run. |
…ethods getSql() first)
649db0c
to
1e0a5b8
Compare
Done! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
=========================================
Coverage 89.48% 89.48%
Complexity 556 556
=========================================
Files 192 192
Lines 2292 2292
=========================================
Hits 2051 2051
Misses 241 241 ☔ View full report in Codecov by Sentry. |
Thanks, i will merge it and fix the php cs fixer warnings later on. |
Yw, thanks for the quick response! |
Hello, This plugin is the last I use that need version 2.0. Any plan to release a new version with ORM 3.0 ? Thanks |
Hi @laurentmuller |
Made a start on upgrading to
doctrine/orm^3.0
Done
Lexer
withTokenType
FunctionNode
(getSql()
first)Todo
Not sure what is causing and how to fix this error...
Reproduce error
Run
composer test
If someone has a clue, feel free to takeover the PR or add commits