Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve login system #49

Merged
merged 7 commits into from
Jul 19, 2022
Merged

Conversation

mathiasayivor
Copy link
Collaborator

Closes #36

πŸ‘¨β€πŸ’» Changes proposed

  • Changed data type for isLogged from boolean to object which contains data that can be used for validation after a successful login
  • Changed code in Login.jsx to be compatible with the new state
  • Changed code in App.js to be compatible with the new state
  • Added a new route to server for storing loginIds that were generated after user logs in, which would be validated to ensure that users don't forge their own loginId

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

@vercel
Copy link

vercel bot commented Jul 19, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app.js, login.jsx looks good, some discussions are needed for the backend

__
sema-logo Β Summary: πŸ‘Œ This code looks good

server/index.js Outdated Show resolved Hide resolved
@mathiasayivor
Copy link
Collaborator Author

Made changes to backend as discussed

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

__
sema-logo Β Summary: πŸ‘Œ This code looks good

@Dun-sin Dun-sin merged commit 442afa6 into Dun-sin:main Jul 19, 2022
@mathiasayivor mathiasayivor deleted the improve-login-system branch July 19, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve on login system
2 participants