Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added / Skipped Closure tests #16

Merged

Conversation

torch2424
Copy link
Collaborator

This adds the closures tests (and skips the errors so that the tests / CI still passes). Similar to (takes the tests from): AssemblyScript#1393

The goal here is that we have these tests, and we can slowly start unskipping things as we port over the remaining closure functionality. But still have the CI passing so we can ensure the code we are merging will be good to eventually merge into master 👍

Screenshot from 2020-08-13 15-01-51

@torch2424 torch2424 self-assigned this Aug 13, 2020
Copy link
Owner

@DuncanUszkay1 DuncanUszkay1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@torch2424
Copy link
Collaborator Author

Anytime dude @DuncanUszkay1 ! 😄 👍

@torch2424 torch2424 merged commit acd7952 into first-class-function-closures Aug 13, 2020
@torch2424 torch2424 deleted the first-class-function-closures-tests branch August 13, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants