-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Make ev_range
, ev_range_with_ac
and dcmSupplierName
optional
#340
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 29 29
Lines 1413 1413
=======================================
Hits 1169 1169
Misses 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Now it's ending with the following error: AttributeError: 'NoneType' object has no attribute 'unit' |
It looks like there is a major problem here, and your vehicle will no longer return any EVRange with air conditioning value at all. 😢 Is this information still displayed in the app? |
ev_range
, ev_range_with_ac
and dcmSupplierName
optional
Can you please approve it again @GitOldGrumpy? It really is a shame that we have to touch the models so often. |
Have tested and now all the data is being retrieved for both cars. The EV range with A/C was avaialble in the new app up to a few weeks ago but for some reason Toyota removed it. Also for some reason the App messes up fuel range (miles/km) but not EV range in km. |
Thanks for testing @briandelicata. It's really annoying what Toyota is doing here. |
Seems there was another change in the toyota api which requires to make some fields in the
ElectricResponseModel
optional.This should fix DurgNomis-drol/ha_toyota#248