Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for hvac.py #93

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Add tests for hvac.py #93

merged 1 commit into from
Oct 16, 2021

Conversation

DurgNomis-drol
Copy link
Owner

Even though the coverage is 100% this is not complete as many of the datapoints i have no idea what they can return other then what type. Help is need to test what the different settings returns.

DurgNomis-drol/ha_toyota#66 (reply in thread)

Copy link
Collaborator

@joro75 joro75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Looks ok for me. 👍

@joro75 joro75 merged commit f0b3f4e into master Oct 16, 2021
@DurgNomis-drol DurgNomis-drol deleted the tests-hvac branch October 16, 2021 09:48
@joro75
Copy link
Collaborator

joro75 commented Oct 16, 2021

@DurgNomis-drol In the original description of this PR, you are referring to that more testing is needed to get all the different information values from the MyT endpoints, for all different car models.

I do observe that this will be a common problem, not only for HVAC but also for other sensors and engine types.
This may be off topic for this PR, but shouldn't we start thinking about a separate function (or tool) that just requests the data and then anonimizes the data (stripping vin, user and location data), and makes it possible for the user to share it with us?

@DurgNomis-drol
Copy link
Owner Author

That is actually a great idea!

It should be pretty simple, as we could (maybe?) take advantage of existing functions in api.py and controller.py.

A side note to this, we also need to add censoring to debug output as that would also make it a lot easier to help people. My experience is that people often overlooks censoring private data when posting logs.

@DurgNomis-drol
Copy link
Owner Author

DurgNomis-drol commented Oct 16, 2021

I have separated it into its own issue, so we can track it there. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants