Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging fixes before UM #23

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Merging fixes before UM #23

merged 7 commits into from
Nov 29, 2023

Conversation

mbaas2
Copy link
Contributor

@mbaas2 mbaas2 commented Nov 27, 2023

No description provided.

 where using the "-order" with a numeric vector enclosed in " had no effect.
these should have gone into last commit
on failing tests (or setups) DTest reported SuccessValue as vec when it was scalar
@mbaas2 mbaas2 requested a review from bpbecker November 27, 2023 14:11
Copy link
Contributor

@bpbecker bpbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. SemVer has unlocalized values
  2. Why do you have both Version and SemVer ? I don't see where Version is used in the code anymore.
  3. _LogStatus - MYrc is global
  4. I REALLY object to having i and r as global names.

@mbaas2
Copy link
Contributor Author

mbaas2 commented Nov 28, 2023

1,3,4: sorry, that should have been done before. I've localized them.
2. it's used by the UCMD System (which does not play well with SemVer, as it needs a number)

@bpbecker
Copy link
Contributor

bpbecker commented Nov 28, 2023 via email

@mbaas2
Copy link
Contributor Author

mbaas2 commented Nov 28, 2023

      ]DEVOPS.DTest -?    
───────────────────────────────────────────────────────────────────────────────                                                                                                                                                      
                                                                                                                                                                                                                                     
]DEVOPS.DTest                                                                                                                                                                                                                        
Source: C:\Users\mbaas\Documents\MyUCMDs\DyalogBuild.dyalog                                                                                                                                                                          
Version: 1.85                                                                                                                                                                                                                        
Syntax: up to 999 arguments                                                                                                                                                                                                          
Accepts modifiers -SuccessValue= -clear[=] -coverage[=] -filter= -halt -init -loglvl= -off[=] -order= -quiet -repeat= -setup[=] -suite= -teardown[=] -testlog[=] -tests= -timeout= -trace -ts -verbose                               
 Modifier 'off' accepts only values "0", "1", "2"                                                                                                                                                                                    
                                                                                                                                                                                                                                     
Run (a selection of) functions named test_* from a namespace, file or directory | Version 1.85.4                                                                                                                                     
    ]DEVOPS.DTest {<ns>|<file>|<path>} [-halt] [-filter=string] [-off] [-quiet] [-repeat=n] [-loglvl=n] [-setup[=fn]] [-suite=file] [-teardown[=fn]] [-testlog=logfile] [-tests=] [-ts] [-timeout=t] [-trace] [-verbose] [-clear[=n]]
    [-init] [-order={0|1|"NumVec"}] -SuccessValue=...]                                                                                                                                                                               
]DEVOPS.DTest -?? ⍝ for more info                                                                                                                                                                                                    

The data shown after Version is the output of the Version function.

Copy link
Contributor

@bpbecker bpbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's probably a better way to have handled the version/semantic version issue. For instance, by having the UCMD help system regex that pulls out the version number understand semantic versioning.

@bpbecker bpbecker merged commit fbbab69 into master Nov 29, 2023
@mbaas2 mbaas2 deleted the devt branch August 7, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants