-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging fixes before UM #23
Conversation
where using the "-order" with a numeric vector enclosed in " had no effect.
these should have gone into last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- SemVer has unlocalized values
- Why do you have both Version and SemVer ? I don't see where Version is used in the code anymore.
- _LogStatus - MYrc is global
- I REALLY object to having i and r as global names.
1,3,4: sorry, that should have been done before. I've localized them. |
Please explain #2 - how is it used by the UCMD system?
From: Michael Baas ***@***.***>
Sent: Tuesday, November 28, 2023 4:53 AM
To: Dyalog/DBuildTest ***@***.***>
Cc: Brian Becker ***@***.***>; Review requested ***@***.***>
Subject: Re: [Dyalog/DBuildTest] Merging fixes before UM (PR #23)
1,3,4: sorry, that should have been done before. I've localized them.
2. it's used by the UCMD System (which does not play well with SemVer, as it needs a number)
—
Reply to this email directly, view it on GitHub <#23 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7WFO6XMUZ3XSA5IYAZZ4DYGWX6HAVCNFSM6AAAAAA74DB2ASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGQ3DKNBYGA> .
You are receiving this because your review was requested. <https://github.com/notifications/beacon/AA7WFOZUVOA73HWQANUSOQLYGWX6HA5CNFSM6AAAAAA74DB2ASWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTNBNWYQ.gif> Message ID: ***@***.*** ***@***.***> >
|
The data shown after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's probably a better way to have handled the version/semantic version issue. For instance, by having the UCMD help system regex that pulls out the version number understand semantic versioning.
No description provided.